Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing laminas/laminas-cache dependency to require section #29

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Dec 1, 2021

Q A
Bugfix not really
BC Break no
QA yes

Description

With laminas/laminas-cache v3, every adapter should require laminas/laminas-cache directly. Seems that I failed to add it here for the v2 release of this component.
Fixing it with this PR.
Fixes #27

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added the Bug Something isn't working label Dec 1, 2021
@boesing boesing added this to the 2.0.1 milestone Dec 1, 2021
@boesing boesing linked an issue Dec 1, 2021 that may be closed by this pull request
@boesing boesing merged commit 7603eec into laminas:2.0.x Dec 1, 2021
@boesing boesing deleted the bugfix/require-laminas-cache branch December 1, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filesystem adapter does not require laminas-cache in v3
2 participants