Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some sort of test / reproducer, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest creating a directory in that test, change permissions to read-only using
chmod
and pass that toini_set
to modify sys temp dir for that test.Having something like
try {} finally {}
to restore temp dir back to default to ensure test does not introduce side-effects to other tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys_temp_dir
is of typePHP_INI_SYSTEM
and thus cannot be set during runtime viaini_set
.Setting the
TMPDIR
environment variable works:putenv('TMPDIR=/fasel')
.Edit:
Seems like
putenv('TMPDIR=/fasel')
will also not work in the phpunit context.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is a tmpdir only issue. Whenever a directory is used without write-permissions, that could lead to problems, no?