Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter example in README.md is wrong #125

Closed
rarog opened this issue Jul 5, 2021 · 2 comments · Fixed by #126 or #127
Closed

Adapter example in README.md is wrong #125

rarog opened this issue Jul 5, 2021 · 2 comments · Fixed by #126 or #127
Assignees
@boesing
Labels
Bug Something isn't working Documentation
Milestone
2.11.3

Comments

@rarog
Copy link

rarog commented Jul 5, 2021

Bug Report

Q A
Version(s) 2.11.2

Summary

laminas-cache-adapter-storage-memory is mentioned in the example in README.md, but it should rather be laminas-cache-storage-adapter-memory.

Current behavior

Mention of laminas-cache-adapter-storage-memory.

Expected behavior

Mention of laminas-cache-storage-adapter-memory.
@rarog rarog added the Bug Something isn't working label Jul 5, 2021
@froschdesign
Copy link
Member

froschdesign commented Jul 6, 2021 •
edited

The same problem can be found in the documentation: https://docs.laminas.dev/laminas-cache/installation/#avoid-unused-cache-adapters-are-being-installed

@rarog
Good catch! 👍

@boesing boesing self-assigned this Jul 8, 2021
boesing added a commit to boesing/laminas-cache that referenced this issue Jul 8, 2021
@boesing
bugfix: add reference to existing storage adapter
1c9753f 
Close laminas#125

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing linked a pull request Jul 8, 2021 that will close this issue
bugfix: documentation reference to memory storage adapter #126
Merged
boesing added a commit to boesing/laminas-cache that referenced this issue Jul 8, 2021
@boesing
bugfix: add reference to existing storage adapter
31107e5 
Close laminas#125

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing linked a pull request Jul 8, 2021 that will close this issue
bugfix: documentation reference to memory storage adapter #127
Merged
boesing added a commit to boesing/laminas-cache that referenced this issue Jul 8, 2021
@boesing
bugfix: add reference to existing storage adapter
b8546e2 
Close laminas#125

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to the 2.11.3 milestone Jul 8, 2021
@boesing
Copy link
Member

boesing commented Jul 8, 2021

Closed with #127

@boesing boesing closed this as completed Jul 8, 2021
@github-actions github-actions bot mentioned this issue Jul 8, 2021
Merged
boesing added a commit that referenced this issue Jul 30, 2021
@boesing
bugfix: add reference to existing storage adapter
9bebad5 
Close #125

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boesing boesing

Labels
Bug Something isn't working Documentation
Projects
None yet
Milestone
2.11.3
3 participants
@froschdesign @boesing @rarog