PSR-16 decorator should use maximum key length capability #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apter max key length capability value Signed-off-by: Ivan Ganev <iganev@cytec.bg>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
rework-pull-39
branch
2 times, most recently
from
2950926
to
ef1132b
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
Thanks @iganev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since its very first version, the
PSR-16decorator only accepted keys up to 64 characters.The user iganev provided a solution in #39 which based on the maximum key length capability of the storage adapters.
It seems that most of the storage adapters do return proper key lengths (except redis) and thus, this change seems absolutely legit to me.
So with v2.12.0 I'd introduce this change and with v3.0.0, all adapters returning
-1as maximum key length will be incompatible with thePSR-16decorator.