Deprecate anything related to pattern factories #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pattern factories are quite complex depending on which pattern is used. There are pattern which do require a `StorageInterface` (which is the majority) and those, which don't. Since there is that kind of complexity, upstream already had to write very specific configurations which can be replaced with dedicated factories in upstream projects. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pattern factories are quite complex depending on which pattern is used. There are pattern which do require a
StorageInterface(which is the majority) and those, which don't.Since there is that kind of complexity, upstream already had to write very specific configurations which can be replaced with dedicated factories in upstream projects.
With v2.12.0, we already changed our documentation on how cache pattern should be instantiated:
https://docs.laminas.dev/laminas-cache/pattern/intro/#quick-start
In v3.0.0, there won't be any way to dynamically create cache pattern via factories.