Widening return type hint of SimpleCacheDecorator::translateThrowable method #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowable method Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
boesing
requested changes
Oct 25, 2021
…pleCacheDecorator::translateThrowable method Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
…anslateThrowable method Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
…cheDecorator::translateThrowable method Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
boesing
requested changes
Oct 25, 2021
boesing
added
the
hacktoberfest-accepted
…erface on SimpleCacheDecorator class Signed-off-by: Mario Costa <mariojr.rcosta@gmail.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
changed the title
|
Thanks, @mariojrrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tell us about why this change is necessary:
Are you fixing a bug or providing a failing unit test to demonstrate a bug?
no
How do you reproduce it?
Set up a Filesystem adapter and try to call has/get/set methods of Laminas\Cache\Psr\SimpleCache\SimpleCacheDecorator passing an invalid key such as '127.0.0.1'
What did you expect to happen?
It should throws the Laminas\Cache\Psr\SimpleCache\SimpleCacheInvalidArgumentException with message "The key '127.0.0.1' doesn't match against pattern '/^[a-z0-9_\+\-]*$/Di'"
What actually happened?
It throws a TypeError exception with the following message:
"Return value of Laminas\Cache\Psr\SimpleCache\SimpleCacheDecorator::translateThrowable() must be an instance of Laminas\Cache\Psr\SimpleCache\SimpleCacheException, instance of Laminas\Cache\Psr\SimpleCache\SimpleCacheInvalidArgumentException returned"