CacheItem for PSR-6 needs to start expiring after calling CacheItemInterface#expiresAfter
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `CacheItemInterface#expiresAfter` More details can be found in laminas/laminas-cache-storage-adapter-test#31 Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
Since this change introduces some kind of BC break, I targeted 3.2.x (minor) rather than 3.1.x (patch). |
Ocramius
approved these changes
Jul 10, 2022
…torage-adapter-test` to get rid of unstable `cache/integration-tests` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Ocramius
approved these changes
Aug 10, 2022
|
🚢 the BC concern is very minimal here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This might introduce some kind of BC break.
Prior this change, cache items did not start to expire after calling
CacheItemInterface#expiresAfter.Therefore,
CacheItemInterfaceinstances only started to expire after calling one of the following methods:CacheItemPoolInterface#saveCacheItemPoolInterface#commitWith one of the integration tests we are using for each of our cache adapters, we found out that this is not how cache items should work.
Since
symfony/cacheanddoctrine/cachedo use these integration tests as well, I'd expect that this is a common use-case and thus want to align with these assumptions.Do we want to introduce this slight BC break? I have a few use-cases in mind where one might want to synchronize expiration times of multiple cache items but I would assume that this is not fully breaking a project since whenever one is working with
time,microsecondsmight be different and thusCacheItemPoolInterface#getItemmight return items which are nothiteven tho they should be there from a TTL PoV.