Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stella-maris/clock with psr/clock #263

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 17, 2023

Q A
QA yes

Description

With 3.4.0, the pre PSR-20 ClockInterface was introduced to this package via the dependency of stella-maris/clock. With 0.1.7, the project is extending PSR-20 and thus, can be replaced as long as we conflict with versions lower than 0.1.7.

This PR updates the code to consume PSR interface rather than working group version.

@boesing boesing added this to the 3.11.0 milestone Jul 17, 2023
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests still require adjustment, but then LGTM :)

@boesing boesing force-pushed the qa/remove-stellar-maris-requirement branch 3 times, most recently from fccb864 to 53ef1b0 Compare July 17, 2023 14:08
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the qa/remove-stellar-maris-requirement branch from 53ef1b0 to 5746af1 Compare July 17, 2023 14:13
@boesing
Copy link
Member Author

boesing commented Jul 17, 2023

Handling the BC check issue in laminas/laminas-continuous-integration-action#161

@boesing boesing merged commit c0b8cf6 into laminas:3.11.x Jul 17, 2023
13 of 14 checks passed
@boesing boesing deleted the qa/remove-stellar-maris-requirement branch July 17, 2023 14:18
@boesing boesing linked an issue Jul 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide native support for PSR-20
2 participants