Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.3 #280

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add support for PHP 8.3 #280

merged 2 commits into from
Nov 6, 2023

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 3, 2023

No description provided.

Ocramius
Ocramius approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius self-assigned this Nov 5, 2023
@Ocramius Ocramius added this to the 3.12.0 milestone Nov 5, 2023
@Ocramius Ocramius changed the base branch from 3.11.x to 3.12.x November 5, 2023 13:08
@boesing
Copy link
Member

boesing commented Nov 6, 2023

Nice, thanks.
I'll revert the psalm bump and baseline changes as I'd like to address these "issues" by adding generics to those "*Options" classes.

@boesing @fezfez
Adds PHP 8.3 as new supported version
03afc62 
Co-authored-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: add missing property to prevent dynamic property deprecation message
7ad2133 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
boesing approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the psalm bump and applied some changes to the abstract pattern test to remove the dynamic property assertion.

@boesing boesing merged commit 66cf9a2 into laminas:3.12.x Nov 6, 2023
16 checks passed
@boesing boesing changed the title Adds PHP 8.3 as new supported version Add support for PHP 8.3 Nov 6, 2023
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
@glo71317 glo71317 mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@boesing boesing boesing approved these changes

Assignees

@Ocramius Ocramius

@boesing boesing

Labels
Enhancement
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fezfez @boesing @Ocramius