New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CallbackCache: simplify calling function/method #63
Conversation
LGTM so far. |
Hm, I was wondering if I could backport this to v2 but actually, this is a BC break. laminas-cache/src/Pattern/ClassCache.php Line 99 in 15e0b44
I will rebase this PR against 3.0.x as it contains GHA so we can see the failing tests in here. |
Wait what? I've tried to rebase against 2.12.x but that led into failing tests. Okay, somehow the names of the test classes changed due to some of the changes made back in february. I've fixed that with #103 and rebased against 3.0.x now. |
@boesing should be fine now |
Thanks, Marc. |
I don't see any bc break here. It's just an internal optimisation. |
Signed-off-by: Marc Bennewitz <m.bennewitz@dcmn.com>
Signed-off-by: Marc Bennewitz <m.bennewitz@dcmn.com>
GHA have major outage as of https://www.githubstatus.com/incidents/zbpwygxwb3gw Verified functionality locally on all three PHP versions. |
Description
Simplified calling the underlying function/method of CallbackCache (and ObjectCache and ClassCache)