Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer php constraints with , are not supported #86

Open
boesing opened this issue Apr 6, 2022 · 3 comments · May be fixed by #119
Open

Composer php constraints with , are not supported #86

boesing opened this issue Apr 6, 2022 · 3 comments · May be fixed by #119
Labels
Bug Something isn't working

Comments

@boesing
Copy link
Member

boesing commented Apr 6, 2022

Bug Report

Q A
Version(s) 1.11.5

Summary

When a component uses a more complex constraint which contains ,, the matrix is not able to infer supported PHP versions anymore.

Current behavior

Supported PHP versions are not detected at all.

How to reproduce

composer.json

{
    "require": {
        "php": ">=5.6,<=8.1.99"
    }
}

Expected behavior

All versions between PHP 5.6 and 8.1.99 are detected. As of writing this issue, this would be:

  • 5.6
  • 7.0
  • 7.1
  • 7.2
  • 7.3
  • 7.4
  • 8.0
  • 8.1
@boesing boesing added the Bug Something isn't working label Apr 6, 2022
boesing added a commit to boesing/laminas-ci-matrix-action that referenced this issue Aug 10, 2022
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing linked a pull request Aug 10, 2022 that will close this issue
@internalsystemerror
Copy link
Member

internalsystemerror commented Aug 11, 2022

Would a better way not be to just replace , with || or a space?

@Ocramius
Copy link
Member

@internalsystemerror , means AND, while || means OR 🤔

@internalsystemerror
Copy link
Member

@Ocramius I've just been reviewing the semver guide on npm https://www.npmjs.com/package/semver and I believe , -> (space) would be the only transformation necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants