Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node to v19 and enforce strict engine checks #141

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Bump node to v19 and enforce strict engine checks #141

merged 2 commits into from
Nov 2, 2022

Conversation

internalsystemerror
Copy link
Member

@internalsystemerror internalsystemerror commented Nov 2, 2022 •
edited
Loading

Q A
Documentation yes
Bugfix yes
BC Break no
New Feature yes
RFC no
QA yes

Description

This PR:

  • Closes Bump package.json to use node:^19 #140.
  • Enforces strict engine checks causing install to error instead of warn should the wrong node or npm version be used.
  • Updates the lock file to include the engine change.

@internalsystemerror internalsystemerror added this to the 1.20.0 milestone Nov 2, 2022
bump to node v19 and enforce strict engine checks
5e6b59e 
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Member Author

We've been running on node 16 all this time? :o

force use of node 19 in CI checks
5733094 
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@Ocramius Ocramius self-assigned this Nov 2, 2022
@Ocramius
Copy link
Member

Ocramius commented Nov 2, 2022

Thanks @internalsystemerror!

@Ocramius Ocramius merged commit 729bd9b into laminas:1.20.x Nov 2, 2022
@internalsystemerror internalsystemerror deleted the enforce-node-version branch November 2, 2022 15:20
@internalsystemerror internalsystemerror mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Bump package.json to use node:^19
2 participants
@internalsystemerror @Ocramius