Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checks job must have the configured extensions and ini #25

Closed
wants to merge 1 commit into from

Conversation

Slamdunk
Copy link

@Slamdunk Slamdunk commented Apr 8, 2021

See https://github.com/laminas/laminas-cache-storage-adapter-apcu/pull/6/checks?check_run_id=2295992531

Even on No checks job the dependencies are installed, so the extensions and ini settings configured by .laminas-ci.json file must be in place

Signed-off-by: Filippo Tessarotto <zoeslam@gmail.com>
@boesing
Copy link
Member

boesing commented Apr 8, 2021

Yup, I've seen the same. I'd prefer going the other way and avoid to checkout or install composer dependencies at all.
For this, I've created two PRs:

laminas/laminas-continuous-integration-action#23
#26

But #26 introduces a BC break. Lets wait for Matthews review to see if the BC break is a real problem as the GHA always checks out the latest versions of the actions.

@boesing
Copy link
Member

boesing commented Apr 8, 2021

I've applied a non-breaking change with an empty command and thus added two new PRs:

laminas/laminas-continuous-integration-action#24
#27

But I think we can apply this PR anyways as its not wrong either.

@weierophinney
Copy link
Member

Closing in favor of #27 and laminas/laminas-continuous-integration-action#24, as that combination does not involve a BC break, and does not require aggregating INI and extension information (as it leads to a no-op).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants