Allow toggling --ignore-platform-reqs option on PHP 8.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the beginning of development on this action, we've used the `--ignore-platform-reqs` flag when installing dependencies on PHP 8. However, with more packages in the Composer ecosystem supporting PHP 8, we can often safely remove that option and still successfully install packages. To enable that behavior in a BC way, this patch adds the ability to provide an `ignore_platform_reqs_8` flag via configuration. By default, the value is `true`, but the configuration allows you to disable it. Actions working in conjunction with this one can thus opt-in to the configuration option to determine whether or not to toggle that Composer option. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-continuous-integration-action
that referenced
this pull request
Apr 20, 2021
This patch adds support for the `ignore_platform_reqs_8` job flag introduced in laminas/laminas-ci-matrix-action#28. When missing, the assumption is to ignore the PHP platform requirement when installing dependencies on PHP 8 (current behavior). Otherwise, the flag value indicates whether or not to use the flag. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-continuous-integration-action
that referenced
this pull request
Apr 20, 2021
This patch adds support for the `ignore_platform_reqs_8` job flag introduced in laminas/laminas-ci-matrix-action#28. When missing, the assumption is to ignore the PHP platform requirement when installing dependencies on PHP 8 (current behavior). Otherwise, the flag value indicates whether or not to use the flag. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the beginning of development on this action, we've used the
--ignore-platform-reqsflag when installing dependencies on PHP 8. However, with more packages in the Composer ecosystem supporting PHP 8, we can often safely remove that option and still successfully install packages. To enable that behavior in a BC way, this patch adds the ability to provide anignore_platform_reqs_8flag via configuration. By default, the value istrue, but the configuration allows you to disable it. Actions working in conjunction with this one can thus opt-in to the configuration option to determine whether or not to toggle that Composer option.Usage:
{ "ignore_platform_reqs_8": false }