Provide proper job names for github UI #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is based on the feedback from @Ocramius in laminas#76 and provides better namings to github UI. This will also prevent laminas#31 with its extended commands where we do check for linting before actually executing the command itself. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
commented
Mar 3, 2022
|
|
||
| if (jobValue === exclusionValue) { | ||
| matches += 1; | ||
| } else if (excludeKey === 'name' && job.deprecatedName !== '' && exclusionValue === job.deprecatedName) { |
There was a problem hiding this comment.
This is actually the BC layer for the issue mentioned in #76 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature is based on the feedback from @Ocramius in #76 and provides better namings to github UI.
This will also prevent #31 with its extended commands where we do check for linting before actually executing the command itself.