Ensure unknown commands do not trigger a container lookup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
force-pushed
the
fix/undefined-command
branch
from
cc8aabc
to
7d31222
Compare
…om container Updates `AbstractContainerCommandLoader::hasCommand()` to test if the `$name` exists in the `$commandMap` before attempting to check the container. If not, it immediately returns false. Fixes laminas#64 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
fix/undefined-command
branch
from
7d31222
to
d3fd1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
AbstractContainerCommandLoader::hasCommand()to test if the$nameexists in the$commandMapbefore attempting to check the container.If not, it immediately returns false.
Fixes #64