Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed code sample showing listener being added, use subscribers instead #95

Merged
merged 2 commits into from Jul 8, 2022
Merged

Fixed code sample showing listener being added, use subscribers instead #95

merged 2 commits into from Jul 8, 2022

Conversation

dkmuir
Copy link
Contributor

@dkmuir dkmuir commented Jul 8, 2022 •
edited

ErrorListener needs to be attached using addSubscriber() instead of addListener()

Signed-off-by: dkmuir david@davidkmuir.com

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Sample code for ConsoleEventDispatcherFactory is wrong.

@dkmuir
Fixed code sample showing listener being added
7e2bad5 
ErrorListener needs to be attached using addSubscriber() instead of addListener()

Signed-off-by: dkmuir <david@davidkmuir.com>
Ocramius
Ocramius requested changes Jul 8, 2022
View reviewed changes
docs/book/events.md Show resolved Hide resolved
@dkmuir
Updated documentation to include addSubscriber
44c365c 
Updated the documentation reference to addListener to addSubscriber instead.
Added line regarding use of addListener for callable

Signed-off-by: dkmuir <david@davidkmuir.com>
Ocramius
Ocramius approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dkmuir!

@Ocramius Ocramius added Documentation Improvements or additions to documentation Enhancement labels Jul 8, 2022
@Ocramius Ocramius added this to the 1.5.0 milestone Jul 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Jul 8, 2022

CI failures are unrelated:

Error: docs/book/index.md:6:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:8:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:10:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:12:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:14:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:16:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Error: docs/book/index.md:18:2 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

@Ocramius Ocramius self-assigned this Jul 8, 2022
@Ocramius Ocramius changed the title Fixed code sample showing listener being added Fixed code sample showing listener being added, use subscribers instead Jul 8, 2022
@Ocramius Ocramius merged commit d98e0d0 into laminas:1.5.x Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign left review comments

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Documentation Improvements or additions to documentation Enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkmuir @Ocramius @froschdesign