Support generating properties, constants and parameter default values with ENUM references #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rastusik <mfris@pixelfederation.com>
Signed-off-by: Rastusik <mfris@pixelfederation.com>
…type inference/analysis Signed-off-by: Marco Pivetta <ocramius@gmail.com>
…code won't make sense out of context Generated code should **NEVER** consider its current namespace, or else it becomes a huge scope backtracking spaghetti mess. This change ensures that the generated ENUM reference is always using the ENUM FQCN. Also, this test ensures that automatic inference of ENUM types in the `ValueGenerator` works as expected. Signed-off-by: Marco Pivetta <ocramius@gmail.com>
Ocramius
changed the title
|
Thanks @Rastusik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and adjusted version of #143.
With this change, ENUMs can be used as default values in generated code (properties, parameters, etc).
Closes #143