Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix erros with composer commands #19

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

kpicaza
Copy link
Contributor

@kpicaza kpicaza commented Oct 27, 2020

Signed-off-by: kpicaza 1093654+kpicaza@users.noreply.github.com

Q A
Bugfix yes
BC Break yes

Description

The error described in issue #18, it affects:

  • composer check
  • composer why
  • composer depends
  • composer prohibits
  • composer show --self
  • composer check-platform-reqs
  • composer home

This way we ensure to only instantiate RootPackageRepository once and only instantiate it in "post-package-install" event context, avoiding the error in listed commands.

@weierophinney weierophinney changed the base branch from 2.4.x to 2.3.x October 27, 2020 21:13
@weierophinney weierophinney changed the base branch from 2.3.x to 2.4.x October 27, 2020 21:19
Signed-off-by: kpicaza <1093654+kpicaza@users.noreply.github.com>
@weierophinney weierophinney changed the base branch from 2.4.x to 2.3.x October 27, 2020 21:21
@weierophinney weierophinney added this to the 2.3.2 milestone Oct 27, 2020
@weierophinney weierophinney added the Bug Something isn't working label Oct 27, 2020
weierophinney added a commit that referenced this pull request Oct 27, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit dfbeb77 into laminas:2.3.x Oct 27, 2020
@svycka
Copy link

svycka commented Oct 28, 2020

thanks, it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants