Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. add return statement to Adapter::getHelpers method; #49

Closed
2 of 7 tasks
michalbundyra opened this issue Jan 16, 2020 · 5 comments
Closed
2 of 7 tasks

1. add return statement to Adapter::getHelpers method; #49

michalbundyra opened this issue Jan 16, 2020 · 5 comments

Comments

@michalbundyra
Copy link
Member

Class Zend\Db\Adapter\Adapter method getHelpers, you guys forget to return the $functions

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

Originally posted by @darluc at zendframework/zend-db#319

@michalbundyra
Copy link
Member Author

@darluc you should probably provide a unit test that reproduces the bug as well.


Originally posted by @malukenho at zendframework/zend-db#319 (comment)

@michalbundyra
Copy link
Member Author

@malukenho okay, I'll try.


Originally posted by @darluc at zendframework/zend-db#319 (comment)

@samsonasik
Copy link
Member

Adapter::getHelpers() is going to be removed. ref #170

@michalbundyra
Copy link
Member Author

@samsonasik this seems to be a bug, so it should not be closed but resolved, as removing is BC break.

If this method is no-op, then it does not matter, I guess.

@michalbundyra michalbundyra reopened this Jul 24, 2020
@weierophinney
Copy link
Member

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants