Correctly types $event property as ?EventFeature\TableGatewayEvent instead of null #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly types $event property to EventInterface instead of just null Signed-off-by: Joey Smith <jsmith@webinertia.net> Signed-off-by: Joey Smith <jsmith@webinertia.net>
Ocramius
reviewed
Apr 1, 2024
| @@ -23,7 +24,7 @@ class EventFeature extends AbstractFeature implements | |||
| /** @var EventManagerInterface */ | |||
| protected $eventManager; | |||
|
|
|||
| /** @var null */ | |||
| /** @var ?EventInterface */ | |||
There was a problem hiding this comment.
EventFeature\TableGatewayEvent, no?
There was a problem hiding this comment.
Yea, I suppose it should be limited to TableGatewayEvent. Im currently adding a custom feature is when I noticed it. But since this is focused on the EventFeature it should be the narrower TableGatewayEvent. Will update here in just a second.
Signed-off-by: Joey Smith <jsmith@webinertia.net> Signed-off-by: Joey Smith <jsmith@webinertia.net>
Tyrsson
changed the title
Ocramius
approved these changes
Apr 1, 2024
|
Sigh, MSSQL is broken again 🙄 |
|
@Tyrsson this needs a rebase on |
Ocramius
added
Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly types $event property to EventInterface instead of just null
Description