Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer update with version 1 throws AssertionError #23

Closed
rieschl opened this issue Oct 27, 2020 · 1 comment
Closed

composer update with version 1 throws AssertionError #23

rieschl opened this issue Oct 27, 2020 · 1 comment
Labels
Bug Something isn't working
Milestone
2.0.0

Comments

@rieschl
Copy link
Contributor

rieschl commented Oct 27, 2020

Bug Report

Q A
Version(s) 2.0.0beta1

When using 2.0.0beta1 and issuing a composer update with version 1 of composer, it throws an AssertionError:

PHP Fatal error: Uncaught AssertionError: assert($rewriter instanceof DependencySolvingCapableInterface) in /mnt/e/PhpStormProjects/laminas/test-mvc-co2/vendor/laminas/laminas-dependency-plugin/src/DependencyRewriterPluginDelegator.php:69

It only occurs if the corresponding assert. settings in php.ini are active.

The execution itself works because DependencyRewriterV1 does implement the method onPreDependenciesSolving which DependencySolvingCapableInterface requires.

It seems, that adding implements DependencySolvingCapableInterface to DependencyRewriterV1 solves the error.
@rieschl rieschl mentioned this issue Oct 28, 2020
Merged
@weierophinney weierophinney added this to the 2.0.0 milestone Oct 30, 2020
@weierophinney weierophinney added the Bug Something isn't working label Oct 30, 2020
@weierophinney
Copy link
Member

Fixed with #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@weierophinney @rieschl