Fix: DependencyRewriterV1 should implement DependencySolvingCapableInterface #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface Signed-off-by: Thomas Rieschl <thomas@trinet.at>
Codecov Report
@@ Coverage Diff @@
## 2.0.x #24 +/- ##
=========================================
Coverage 92.37% 92.37%
Complexity 100 100
=========================================
Files 5 5
Lines 341 341
=========================================
Hits 315 315
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DependencyRewriterV1currently implements the required method ofDependencySolvingCapableInterfacebut the class itself doesn't say that in its signature, so the Assertion in the plugin fails.This PR fixes that.
fixes #23