fix: ensure replacement package is installed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing, we discovered that while composer reports installing Laminas packages for nested dependencies, the actual packages installed were ZF packages. (Determined by examining the contents of the vendor directory.) The solution was to update the `OperationInterface` with the replacement package found via the repository manager, instead of updating the package with the desired name. Replacing the package instance in the operation ensures that the actual package is installed. One note: packages slip-streamed in this way do not return meaningful information via `composer why`. I am not certain there is a way to make that happen.
weierophinney
force-pushed
the
hotfix/proper-package-replacement
branch
from
66cf938
to
3448ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In testing, we discovered that while composer reports installing Laminas packages for nested dependencies, the actual packages installed were ZF packages. (Determined by examining the contents of the vendor directory.)
The solution was to update the
OperationInterfacewith the replacement package found via the repository manager, instead of updating the package with the desired name. Replacing the package instance in the operation ensures that the actual package is installed.One note: packages slip-streamed in this way do not return meaningful information via
composer why. I am not certain there is a way to make that happen.