Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: pass --ignore-platform-reqs and --ignore-platform-req to composer update --lock #29

Merged
merged 2 commits into from
Feb 15, 2021
Merged

bugfix: pass --ignore-platform-reqs and --ignore-platform-req to composer update --lock #29

merged 2 commits into from
Feb 15, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Dec 8, 2020

Q A
Bugfix yes

Description

Fixes #28

@boesing boesing added the Bug Something isn't working label Dec 8, 2020
@boesing boesing added this to the 2.1.1 milestone Dec 8, 2020
@boesing boesing added this to In progress in Composer v2 via automation Dec 8, 2020
@boesing boesing linked an issue Dec 8, 2020 that may be closed by this pull request
Ignored platform requirements are not passed to lock update command #28
Closed
@boesing boesing force-pushed the bugfix/pass-platform-ignore-arguments branch from b6d2bcc to a0d4e8e Compare December 8, 2020 22:15
@boesing
Copy link
Member Author

boesing commented Dec 8, 2020

Relates to laminas/laminas-servicemanager#64

Composer v2 automation moved this from In progress to Reviewer approved Dec 8, 2020
boesing
boesing commented Dec 14, 2020
View reviewed changes
src/DependencyRewriterV2.php Outdated Show resolved Hide resolved
@boesing boesing marked this pull request as draft December 14, 2020 08:05
@boesing boesing force-pushed the bugfix/pass-platform-ignore-arguments branch from a0d4e8e to dbc1240 Compare February 15, 2021 13:57
@boesing boesing marked this pull request as ready for review February 15, 2021 14:08
@boesing boesing changed the base branch from 2.1.x to 2.2.x February 15, 2021 14:08
@boesing boesing modified the milestones: 2.1.1, 2.2.0 Feb 15, 2021
@boesing boesing force-pushed the bugfix/pass-platform-ignore-arguments branch 3 times, most recently from 998fbdd to f303cf6 Compare February 15, 2021 14:22
@boesing boesing changed the base branch from 2.2.x to 2.1.x February 15, 2021 14:48
@boesing boesing force-pushed the bugfix/pass-platform-ignore-arguments branch 2 times, most recently from 705fcbe to 921bc20 Compare February 15, 2021 14:50
@boesing
bugfix: pass --ignore-platform-reqs and --ignore-platform-req to …
70ab2ab 
…`composer update --lock`

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: add CHANGELOG entry
9015202 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the bugfix/pass-platform-ignore-arguments branch from 921bc20 to 9015202 Compare February 15, 2021 14:50
@boesing boesing modified the milestones: 2.2.0, 2.1.1 Feb 15, 2021
@boesing boesing merged commit d7d079f into laminas:2.1.x Feb 15, 2021
Composer v2 automation moved this from Reviewer approved to Done Feb 15, 2021
@boesing boesing deleted the bugfix/pass-platform-ignore-arguments branch February 15, 2021 14:56
@boesing boesing mentioned this pull request Feb 15, 2021
Closed
@github-actions github-actions bot mentioned this pull request Feb 15, 2021
Merged
@boesing boesing mentioned this pull request Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapshotpl snapshotpl snapshotpl approved these changes

@weierophinney weierophinney Awaiting requested review from weierophinney

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
No open projects
Composer v2
  
Done
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

Ignored platform requirements are not passed to lock update command
3 participants
@boesing @weierophinney @snapshotpl