PHP 8.0 support #15

arueckauer · 2020-11-14T16:39:57Z

Q	A
Documentation	no
Bugfix	no
BC Break	yes/no
New Feature	no
RFC	no
QA	yes

Description

This PR provides provides changes described in #12.

Fixes #12

Upgrade phpunit/phpunit to 9.3 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Drop support for PHP less then 7.3 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

…havior Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

arueckauer · 2020-11-14T16:56:12Z

Hi @boesing 👋🏻

It seems Travis configuration needs some update for PHP nightly builds. I am unsure how to fix that. Has this issue been solved in another component where PHP 8 support has been added?

boesing · 2020-11-17T23:42:43Z

Hm, when I understand this correct, its because of the TESTS_LAMINAS_DIAGNOSTICS_APCU_ENABLED global environment var.

We should install apcu 5.1.19 as it is compatible with PHP 8.0.
You can have a look at laminas-cache-storage-adapter-apcu to see how to install pecl extensions during CI.

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

arueckauer · 2020-11-18T08:47:22Z

Thanks for the input. APCu now works.

Since Memcached is not yet supported for PHP 8.0 (see latest version 3.1.5), I disabled it.

For MongoDB I added the 1.9.0RC1 which adds support for PHP 8. Unfortunately the build was not executed, due to a negative credit balance in Travis.

Owner laminas does not have enough credits.

boesing · 2020-11-18T14:35:06Z

Thanks for the changes. We might want to have a look when travis is back up and running. 👍

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

arueckauer · 2020-11-18T22:50:15Z

@boesing Builds are generally running again, but the latest push did not trigger Travis. Can you manually start the build process?

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Change PHP version to 8.0 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

mathieupetrini · 2020-12-26T21:40:04Z

Hi,

bovigo/vfsStream#232 has been merged.
Is it possible to restart failing jobs ?

samsonasik · 2020-12-27T13:46:26Z

restarted

phpunit.xml.dist

Ocramius · 2020-12-28T08:53:20Z

test/GuzzleHttpServiceTest.php

    {
+        self::markTestSkipped('Clarify what to do with assertion of protected property.');


To be discussed before merging

Yeah, just use reflection for now as it might test something which has been fixed before.
I dont really like checking protected/private properties at all but this is done in so many packages and I dont get the reason behind that...

Urgh, this went under my radar: OK to merge without it

boesing

LGTM

Please remove the skipped test for guzzle and use reflection for now to make the test pass.

boesing · 2021-01-01T14:46:58Z

test/GuzzleHttpServiceTest.php

    {
+        self::markTestSkipped('Clarify what to do with assertion of protected property.');


Yeah, just use reflection for now as it might test something which has been fixed before.
I dont really like checking protected/private properties at all but this is done in so many packages and I dont get the reason behind that...

- Adds a coding standards workflow - Adds a unit tests workflow - Removes Travis configuation Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

Unreleased, so having to alias for now. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

warning is no longer raised; type error is raised instead. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

weierophinney · 2021-01-25T23:35:21Z

I've taken the liberty of amending this with changes to the CI pipeline. We're moving off of Travis to GHA, and I plan to provide fixes per the feedback provided already... but we're out of Travis minutes for the month, so first step is getting a working CI pipeline. 😄

As you can see, all green at this stage, and we have tests against all expected services.

Ocramius · 2021-01-26T10:31:29Z

composer.json

        "laminas/laminas-zendframework-bridge": "^1.0"
    },
    "require-dev": {
        "doctrine/migrations": "^1.0 || ^2.0",
        "guzzlehttp/guzzle": "^5.3.3 || ^6.3.3",
        "laminas/laminas-coding-standard": "~1.0.0",
        "laminas/laminas-loader": "^2.0",
-        "mikey179/vfsstream": "^1.6",
+        "mikey179/vfsstream": "dev-master#08a798577d677436f4f4ea3d0b3c949f64655548 as 1.6.9",


To be changed before merge

Hmm, no, only require-dev: I'd say "roll with it"

Until they have a release that includes that commit... it is what it is. :)

Ocramius · 2021-01-26T10:33:47Z

We're moving off of Travis to GHA

@weierophinney the GHA setup used here seems to be a bit wonky, but in the interest of getting anything running at this point, I would say 🚢

arueckauer added 6 commits November 14, 2020 17:40

Update supported PHP versions

0d757a4

Upgrade phpunit/phpunit to 9.3 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Update PHPUnit configuration to best practice

41c141c

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Update tests to run with PHPUnit 9.3

2e95601

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Add line break before 120 characters as defined by Coding Standard

a566a98

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Add PHP 8 support

0f1d0da

Drop support for PHP less then 7.3 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Remove fail on risky and warning configuration to restore previous be…

122d2e2

…havior Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

boesing added the Enhancement label Nov 17, 2020

boesing added this to In progress in PHP 8.0 via automation Nov 17, 2020

boesing linked an issue Nov 17, 2020 that may be closed by this pull request

PHP 8.0 support #12

Closed

6 tasks

arueckauer added 5 commits November 18, 2020 07:21

Add PHP 8.0 compatible APCu version

9c60df9

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Fix YAML line indentation

b775235

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Remove command to add config which is irrelevant for this component

d3b2358

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Disable Memcached for PHP 8.0 since there is not support for it yet

80ad20c

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Add PHP 8.0 compatible MongoDB version

f167561

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

arueckauer marked this pull request as ready for review November 18, 2020 08:47

Use local XML schema definition

474e22d

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Move Composer argument --ignore-platform-reqs to nightly builds

5aa0062

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

lepiaf mentioned this pull request Dec 8, 2020

Add support for PHP 8 liip/LiipMonitorBundle#251

Merged

arueckauer added 2 commits December 11, 2020 07:10

Update build matrix

54a45b0

Change PHP version to 8.0 Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

Upgrade phpunit/phpunit to 9.4

546670a

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>

PHP 8.0 automation moved this from In progress to Review in progress Dec 28, 2020

Ocramius requested changes Dec 28, 2020

View reviewed changes

boesing requested changes Jan 1, 2021

View reviewed changes

froschdesign mentioned this pull request Jan 15, 2021

PDOCheck.php extends AbstractCheck #14

Closed

weierophinney mentioned this pull request Jan 25, 2021

Support for doctrine/migrations:^3 #10

Merged

weierophinney added 3 commits January 25, 2021 17:01

qa: switch to GHA instead of Travis

7535282

- Adds a coding standards workflow - Adds a unit tests workflow - Removes Travis configuation Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

qa: use version of vfsstream that supports PHP 8

381f1f2

Unreleased, so having to alias for now. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

fix: fix failing test under PHP 8

7bfa287

warning is no longer raised; type error is raised instead. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>

Ocramius approved these changes Jan 26, 2021

View reviewed changes

Ocramius changed the base branch from 1.6.x to 1.7.x January 26, 2021 10:37

Ocramius self-assigned this Jan 26, 2021

Ocramius added this to the 1.7.0 milestone Jan 26, 2021

Ocramius merged commit e396469 into laminas:1.7.x Jan 26, 2021

PHP 8.0 automation moved this from Review in progress to Done Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.0 support #15

PHP 8.0 support #15

arueckauer commented Nov 14, 2020 •

edited by Ocramius

Loading

arueckauer commented Nov 14, 2020

boesing commented Nov 17, 2020

arueckauer commented Nov 18, 2020

boesing commented Nov 18, 2020

arueckauer commented Nov 18, 2020

mathieupetrini commented Dec 26, 2020

samsonasik commented Dec 27, 2020

Ocramius Dec 28, 2020

boesing Jan 1, 2021

Ocramius Jan 26, 2021

boesing left a comment

boesing Jan 1, 2021

weierophinney commented Jan 25, 2021

Ocramius Jan 26, 2021

Ocramius Jan 26, 2021

weierophinney Jan 26, 2021

Ocramius commented Jan 26, 2021

		{
		self::markTestSkipped('Clarify what to do with assertion of protected property.');

PHP 8.0 support #15

PHP 8.0 support #15

Conversation

arueckauer commented Nov 14, 2020 • edited by Ocramius Loading

Description

arueckauer commented Nov 14, 2020

boesing commented Nov 17, 2020

arueckauer commented Nov 18, 2020

boesing commented Nov 18, 2020

arueckauer commented Nov 18, 2020

mathieupetrini commented Dec 26, 2020

samsonasik commented Dec 27, 2020

Ocramius Dec 28, 2020

Choose a reason for hiding this comment

boesing Jan 1, 2021

Choose a reason for hiding this comment

Ocramius Jan 26, 2021

Choose a reason for hiding this comment

boesing left a comment

Choose a reason for hiding this comment

boesing Jan 1, 2021

Choose a reason for hiding this comment

weierophinney commented Jan 25, 2021

Ocramius Jan 26, 2021

Choose a reason for hiding this comment

Ocramius Jan 26, 2021

Choose a reason for hiding this comment

weierophinney Jan 26, 2021

Choose a reason for hiding this comment

Ocramius commented Jan 26, 2021

arueckauer commented Nov 14, 2020 •

edited by Ocramius

Loading