Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for php-amqplib:^3.0 #22

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Add support for php-amqplib:^3.0 #22

merged 4 commits into from
Jul 9, 2021

Conversation

sbacelic
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Summary

AMQPConnection used in RabbitMQ check has been removed in php-amqplib v3: php-amqplib/php-amqplib#897 so I added support for it.

@REBELinBLUE
Copy link

Any chance of getting this released? php-amqplib 3.0 is required for using PHP 8

@sbacelic
Copy link
Contributor Author

Any chance of getting this released? php-amqplib 3.0 is required for using PHP 8

@REBELinBLUE you can fork this PR or use the forked version in composer.json until this is not resolved:

"repositories": [
        {
            "type": "vcs",
            "url":  "https://github.com/sbacelic/laminas-diagnostics"
        }
    ],
  ...
  "laminas/laminas-diagnostics": "1.9.x-dev"

@REBELinBLUE
Copy link

REBELinBLUE commented Apr 19, 2021

for now I have added the following file

<?php

declare(strict_types=1);

namespace PhpAmqpLib\Connection;

// FIXME: Remove this once https://github.com/laminas/laminas-diagnostics/pull/22 has been released and
// https://github.com/liip/LiipMonitorBundle has been updated
class AMQPConnection extends AMQPStreamConnection
{
}

to my code and added it to the autoloader classmap, because it would still require LiipMonitorBundle to be updated to use the new version of this library.

sbacelic and others added 4 commits July 9, 2021 12:14
Signed-off-by: Bas <bas@onehop.com.hk>
Signed-off-by: Bas <bas@onehop.com.hk>
Signed-off-by: Bas <bas@onehop.com.hk>
…amqplib missing in either 2.x or 3.x flavor
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbacelic!

@Ocramius Ocramius merged commit 8ec79ba into laminas:1.9.x Jul 9, 2021
@Ocramius Ocramius changed the title Add support for php-amqplib 3.0 Add support for php-amqplib:^3.0 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants