Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertion usages in test suite #9

Merged
merged 3 commits into from Jan 11, 2021

Conversation

peter279k
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no
Tests yes

Description

  • Using the assertCount to assert expected count is same as result count.
  • Using the assertSame to assert exception message when catching block has been triggered on some testing methods.
  • Removing some variables because they're declared, but not used.

Signed-off-by: peter279k <peter279k@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I see nothing wrong with this patch, but the component is in "maintenance only" or "security only" mode, so unless we get an active dedicated maintainer for it, we should really not merge improvements 🤔

@Ocramius
Copy link
Member

Tried to re-apply this in #11 (after a rebase), but it won't cleanly apply.

If/when you can, please rebase and let's get this to a green state before merging :-)

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peter279k!

@Ocramius Ocramius changed the base branch from master to 2.9.x January 11, 2021 18:21
@Ocramius Ocramius added this to the 2.9.0 milestone Jan 11, 2021
@Ocramius Ocramius changed the title It's about assertions and assert excpetion message Improve assertion usages in test suite Jan 11, 2021
@Ocramius Ocramius merged commit 1c7101e into laminas:2.9.x Jan 11, 2021
@peter279k peter279k deleted the test_enhancement branch January 11, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants