wip

Signed-off-by: thgs <theogpl57@gmail.com>
laminas · Dec 18, 2023 · 929f0b5 · 929f0b5
1 parent 38d4a5f
commit 929f0b5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -8,3 +8,5 @@
 /laminas-mkdoc-theme/
 /phpunit.xml
 /vendor/
+
+.idea
diff --git a/test/Reader/Http/LaminasHttpClientDecoratorTest.php b/test/Reader/Http/LaminasHttpClientDecoratorTest.php
@@ -234,6 +234,8 @@ public static function invalidHeaders(): iterable
         foreach ($invalidIndividualValues as $key => $value) {
             yield $key => [['X-Test' => [$value]], 'strings or numbers'];
         }
+
+        // todo: expand here with multi values.
     }
 
     /**

diff --git a/test/Reader/Http/ResponseTest.php b/test/Reader/Http/ResponseTest.php
@@ -43,7 +43,8 @@ public function testConstructorCanAcceptHeaders(): void
             'Location'         => 'http://example.org/foo',
             'Content-Length'   => 1234,
             'X-Content-Length' => 1234.56,
-            'MultiValue'       => ['one', 'two']
+            'MultiValue'       => ['one', 'two'],
+            'MultiValue2'      => [1, 2],
 
         ]);
         $this->assertEquals(204, $response->getStatusCode());
@@ -170,6 +171,11 @@ public static function invalidHeaders(): array
                 ['X-Test' => [(object) ['body' => 'BODY']]],
                 'must be a string or numeric',
             ],
+            // todo: expand this with more combinations?
+            'mixed-values-in-array' => [
+                ['X-Test' => ['valid', false]],
+                'must be a string or numeric',
+            ]
         ];
     }