libxml_disable_entity_loader() is deprecated in PHP 8

laminas · Sep 30, 2020 · ee3874f · ee3874f
1 parent 16d251b
commit ee3874f
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/src/Reader/Reader.php b/src/Reader/Reader.php
@@ -315,7 +315,9 @@ public static function importString($string)
         }
 
         $libxmlErrflag = libxml_use_internal_errors(true);
-        $oldValue      = libxml_disable_entity_loader(true);
+        if (LIBXML_VERSION < 20900) {
+            $oldValue = libxml_disable_entity_loader(true);
+        }
         $dom           = new DOMDocument();
         $status        = $dom->loadXML(trim($string));
         foreach ($dom->childNodes as $child) {
@@ -325,7 +327,9 @@ public static function importString($string)
                 );
             }
         }
-        libxml_disable_entity_loader($oldValue);
+        if (LIBXML_VERSION < 20900) {
+            libxml_disable_entity_loader($oldValue);
+        }
         libxml_use_internal_errors($libxmlErrflag);
 
         if (! $status) {
@@ -395,10 +399,14 @@ public static function findFeedLinks($uri)
         }
         $responseHtml  = $response->getBody();
         $libxmlErrflag = libxml_use_internal_errors(true);
-        $oldValue      = libxml_disable_entity_loader(true);
+        if (LIBXML_VERSION < 20900) {
+            $oldValue = libxml_disable_entity_loader(true);
+        }
         $dom           = new DOMDocument();
         $status        = $dom->loadHTML(trim($responseHtml));
-        libxml_disable_entity_loader($oldValue);
+        if (LIBXML_VERSION < 20900) {
+            libxml_disable_entity_loader($oldValue);
+        }
         libxml_use_internal_errors($libxmlErrflag);
         if (! $status) {
             // Build error message
@@ -435,17 +443,21 @@ public static function detectType($feed, $specOnly = false)
         } elseif (is_string($feed) && ! empty($feed)) {
             ErrorHandler::start(E_NOTICE | E_WARNING);
             ini_set('track_errors', 1);
-            $oldValue = libxml_disable_entity_loader(true);
-            $dom      = new DOMDocument();
-            $status   = $dom->loadXML($feed);
+            if (LIBXML_VERSION < 20900) {
+                $oldValue = libxml_disable_entity_loader(true);
+            }
+            $dom    = new DOMDocument();
+            $status = $dom->loadXML($feed);
             foreach ($dom->childNodes as $child) {
                 if ($child->nodeType === XML_DOCUMENT_TYPE_NODE) {
                     throw new Exception\InvalidArgumentException(
                         'Invalid XML: Detected use of illegal DOCTYPE'
                     );
                 }
             }
-            libxml_disable_entity_loader($oldValue);
+            if (LIBXML_VERSION < 20900) {
+                libxml_disable_entity_loader($oldValue);
+            }
             ini_restore('track_errors');
             ErrorHandler::stop();
             if (! $status) {