Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itunes:explicit values have changed #20

Closed
OpenHaus opened this issue Aug 18, 2020 · 3 comments · Fixed by #21
Closed

itunes:explicit values have changed #20

OpenHaus opened this issue Aug 18, 2020 · 3 comments · Fixed by #21
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@OpenHaus
Copy link
Contributor

Bug Report

The values for the itunes:explicit tag on channel and episode level changed to "true/false".

Q A
Version(s) 2.12.2

Summary

According to Apple´s documentation the values for the itunes:explicit tag on channel and episode level are not "yes/clean" anymore but now "true/false".

itunes:explicit

The podcast parental advisory information.The explicit value can be one of the following:true.

If you specify true, indicating the presence of explicit content, Apple Podcasts displays an Explicit parental advisory graphic for your podcast.Podcasts containing explicit material aren’t available in some Apple Podcasts territories.

If you specify false, indicating that your podcast doesn’t contain explicit language or adult content, Apple Podcasts displays a Clean parental advisory graphic for your podcast.

See: https://help.apple.com/itc/podcasts_connect/#/itcb54353390

Current behavior

To mark a channel or episode as explicit "yes" is used. To mark a channel or episode as not explicit "clean" is used.

How to reproduce

Generate a feed with channel or an episode set as explicit.

Expected behavior

A channel or episode marked as explicit should have the value <itunes:explicit>true</itunes:explicit>.
A channel or episode marked as clean / not explicit should have the value <itunes:explicit>false</itunes:explicit>.

@froschdesign froschdesign added the Bug Something isn't working label Aug 18, 2020
@froschdesign froschdesign added this to the 2.12.3 milestone Aug 18, 2020
@froschdesign froschdesign self-assigned this Aug 18, 2020
@froschdesign
Copy link
Member

froschdesign commented Aug 18, 2020

@OpenHaus
Very good catch! Thanks for reporting the problem. I will create a fix for it.

froschdesign added a commit to froschdesign/laminas-feed that referenced this issue Aug 18, 2020
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign froschdesign linked a pull request Aug 18, 2020 that will close this issue
michalbundyra added a commit that referenced this issue Aug 18, 2020
Fixes #20 - itunes:explicit values have changed
@psil67
Copy link

psil67 commented Jun 8, 2024

Apparently the values have changed again. The RSS feed of Wordpress produces
true/false
which is incorrect according to the RSS validator which says it should be
line 36, column 22: itunes:explicit must be "yes", "no", or "clean": false [help]

@froschdesign
Copy link
Member

@psil67
WordPress does not use this package (laminas-feed). Therefore, your problem has landed in the wrong place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants