Create PodcastIndex extension

[codedmonkey]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	yes
QA	yes

Description

Creates an extension for the PodcastIndex namespace, a new namespace that attempts to supplement the existing iTunes podcast namespace with missing features created by @daveajones and @adamc199.

[daveajones]

Would love to see this merged.

[adamc199]

This would be a potential game changer

[weierophinney]

@codedmonkey Please take a look at the Psalm errors: https://travis-ci.com/github/laminas/laminas-feed/jobs/458707070#L795

(you can reproduce them locally by running composer static-analysis)

The errors generally provide links to information detailing the general type of error, and how to correct it. You can also ask in the #contributors channel of the Laminas slack if you need assistance fixing them.

[codedmonkey]

Thanks for the heads up. Looks a lot cleaner now.

[froschdesign]

Thanks for this contribution! 👍

I added some comments and corrections. laminas-feed supports PHP's version 7.3 and higher therefore we can use the correct return types and can omit many duplications in DocBlocks.
And old notations for internal method names do not have to be used.

[froschdesign]

The documentation needs a better introduction for people which do not know anything about "Podcast Index".
And some more unit tests for exception are needed.

Thanks in advance! 👍

[weierophinney]

@codedmonkey Due to a snafu with how Travis-CI allocates OSS hours to projects, we had to put this on the backburner until we had GHA setup for doing CI. I've just rebased your branch against the current 2.14.x source, removing your commit with Psalm baseline changes. If you go to the files tab, you'll see annotations from Psalm detailing what needs to change. What's nice is that it now notes unchanged files that have new issues flagged separately, so we can ignore those during our review. 😄

There are a few related to your new functionality, however...

[codedmonkey]

Thanks @weierophinney, the new system looks very slick.

I finally got my head around how to use Psalm so I regenerated the Psalm baseline for my changes.

[froschdesign]

The Psalm errors are unrelated to this pull request and must be solved in a separate pull request or with version 3 of this component.

The title of the new documentation page needs an update and the comments for the CS fixer should use the new syntax.

Thanks in advance! 👍

[codedmonkey]

I moved the Psalm commit into it's own branch at codedmonkey/laminas-feed#podcastindex-psalm

[froschdesign]

@codedmonkey

I moved the Psalm commit into it's own branch at codedmonkey/laminas-feed#podcastindex-psalm

I'm sorry, my previous comment was misleading. I mean the open error message on Laminas\Feed\Reader\Extension\AbstractEntry and Laminas\Feed\Writer\Extension\AbstractRenderer and so on. Everything else was right. No need to extract this!

[froschdesign]

@codedmonkey
Sorry for the trouble!

The Psalm error messages on Laminas\Feed\Reader\Extension\AbstractEntry or Laminas\Feed\Writer\Extension\AbstractRenderer were listed as not belonging to the changed files of this pull request. And if we added these problems here as well, it would become endless.

See "Unchanged files with check annotations": https://github.com/laminas/laminas-feed/pull/31/files

I hope I have explained it more clearly now.

[froschdesign]

@codedmonkey
Damn, the new syntax for the CS fixer does not work here because the used version 1 of laminas-coding-standard uses an old version of PHP_CodeSniffer. 😞

Can you change that? After that we have everything.

[ocean]

Sorry I missed this conversation - @froschdesign do you still need me to update my code to change the comments? Or has it been covered by a later merge?