Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat admonitions #56

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Reformat admonitions #56

merged 4 commits into from
Jul 18, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 18, 2022

Q A
Documentation yes

Description

Removes unnecessary error suppression

@gsteel
Reformat admonitions
3970511 
- removes unnecessary error suppression

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 2.18.0 milestone Jul 18, 2022
@gsteel gsteel self-assigned this Jul 18, 2022
@gsteel gsteel requested a review from froschdesign July 18, 2022 12:13
@gsteel
Copy link
Member Author

gsteel commented Jul 18, 2022

@froschdesign
I couldn't see "MISSING" as an option at https://squidfunk.github.io/mkdocs-material/reference/admonitions/#supported-types so I went for "NOTE" ?? Correct?

froschdesign
froschdesign requested changes Jul 18, 2022
View reviewed changes
docs/book/find-feeds.md Outdated Show resolved Hide resolved
docs/book/importing.md Outdated Show resolved Hide resolved
docs/book/intro.md Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member

froschdesign commented Jul 18, 2022 •
edited

@gsteel

@froschdesign I couldn't see "MISSING" as an option at https://squidfunk.github.io/mkdocs-material/reference/admonitions/#supported-types so I went for "NOTE" ?? Correct?

MISSING is in the list: "failure, fail, missing"

See also:

Custom look#
As mentioned, styling is handled through CSS, not from the extension itself. And in CSS, you can indeed completely re-define the look for each particular keyword. Adding a new keyword requires no action, other than possibly adding CSS for it.

https://oprypin.github.io/markdown-callouts/#custom-look

https://github.com/laminas/laminas.github.io/blob/3e2faddba0e7d00de92b0b77cb655c4794a742b3/asset/sass/_settings.scss#L18-L46

@gsteel
Update docs/book/intro.md
55064e1 
Co-authored-by: Frank Brückner <info@froschdesignstudio.de>

Signed-off-by: George Steel <george@netglue.uk>
@gsteel
Update docs/book/find-feeds.md
2ffc592 
Co-authored-by: Frank Brückner <info@froschdesignstudio.de>

Signed-off-by: George Steel <george@netglue.uk>
@gsteel
Update docs/book/importing.md
942e061 
Co-authored-by: Frank Brückner <info@froschdesignstudio.de>

Signed-off-by: George Steel <george@netglue.uk>
@Ocramius Ocramius merged commit 67902d4 into laminas:2.18.x Jul 18, 2022
@Ocramius
Copy link
Member

🚢

@gsteel gsteel deleted the doc-admonitions branch July 18, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign requested changes

Assignees

@gsteel gsteel

Labels
Documentation
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsteel @froschdesign @Ocramius