Apply PHP 7.4 syntax and typed property #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHPUnit error is unrelated: Running ./vendor/bin/phpunit
PHP Fatal error: Declaration of Laminas\ServiceManager\AbstractTypedContainerImplementation::has(string $id): bool must be compatible with Laminas\Feed\Reader\ExtensionManagerInterface::has($extension) in /github/workspace/src/Reader/ExtensionPluginManager.php on line 28ref #57 (comment) |
|
@samsonasik please check #59 - if reviewed, I can release and then merge this one on top of it. |
|
@samsonasik a rebase should make this green |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
@Ocramius rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description
Since composer.json require php 7.4, php 7.4 syntax can be applied with typed properties.
final class, typed properties for protected is allowed if no inherit of parent or used by its final class parent.