Update standard-filters' Disable Casting table #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
changed the title
|
For a bugfix, please use the branch of the current release: 2.28.x |
Where the table displayed casting the string 'false' to true and 'true' to false when using `Boolean::TYPE_FALSE_STRING`. Signed-off-by: Remy Bos <27890746+sjokkateer@users.noreply.github.com>
sjokkateer
force-pushed
the
improvement/doc-boolean-type-false-string
branch
from
65f06ac
to
af24959
Compare
My apologies, I believe this should suffice? |
Ocramius
reviewed
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the table under the Disable Casting header (standard-filters.md) displays casting the string
'false'totrueand'true'tofalsewhen usingBoolean::TYPE_FALSE_STRINGin conjunction with theBoolean::classfilter.This seems to be a small error in the documentation when reviewing BooleanTest::typeTestProvider() and BooleanTest::testTypes(), which this PR resolves.
Signed-off-by: Remy Bos 27890746+sjokkateer@users.noreply.github.com
Description