Fixes #5 : Handle Response::sendHeaders() to not silently returns when header already sent #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rns when header already sent Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
travis build green 🎉 |
|
Given the stability of this library, I'm not sure if introducing this BC break at this point will be worth it though 🤔 |
weierophinney
requested changes
Aug 10, 2020
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
travis build green 🎉 |
weierophinney
requested changes
Aug 11, 2020
…nd make expectException* message call immediate call before actual method call Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
travis build green 🎉 |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
@weierophinney I've added documentation for it. |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Co-authored-by: Frank Brückner <info@froschdesignstudio.de> Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
handle-headersent
branch
from
c42c20d
to
8334a2e
Compare
weierophinney
added a commit
that referenced
this pull request
Aug 18, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description
Fixes #5 Handle Response::sendHeaders() to not silently returns when header already sent