Add new test case in ClassMethodsHydratorTest #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test case
weierophinney
added a commit
to weierophinney/laminas-hydrator
that referenced
this pull request
Oct 5, 2020
This patch modifies filters slightly. Previously, they already checked to see if static property notation was provided or not. This extends that slightly to allow passing an optional second argument, a `null` or `object` value representing the instance being extracted or hydrated. For those filters that then use reflection, the `$instance` can be used as the primary argument, and the `$property` argument as the second. This approach allows the `ClassMethodsHydrator` to filter properly based on the specific instance under scrutiny. Additionally, this makes changes to `ClassMethodsHydrator` to: - Detect if an anonymous class was used. - Use the `spl_object_hash()` of that instance for caching the method list. - Pass the `$object` as the `$instance` argument to filters. Finally, I've added tests to each of the hydrators to verify they work as expected when presented with anonymous objects. Fixes laminas#25 Fixes laminas#26 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-hydrator
that referenced
this pull request
Oct 5, 2020
This patch modifies filters slightly. Previously, they already checked to see if static property notation was provided or not. This extends that slightly to allow passing an optional second argument, a `null` or `object` value representing the instance being extracted or hydrated. For those filters that then use reflection, the `$instance` can be used as the primary argument, and the `$property` argument as the second. This approach allows the `ClassMethodsHydrator` to filter properly based on the specific instance under scrutiny. Additionally, this makes changes to `ClassMethodsHydrator` to: - Detect if an anonymous class was used. - Use the `spl_object_hash()` of that instance for caching the method list. - Pass the `$object` as the `$instance` argument to filters. Finally, I've added tests to each of the hydrators to verify they work as expected when presented with anonymous objects. Fixes laminas#25 Fixes laminas#26 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-hydrator
that referenced
this pull request
Oct 6, 2020
This patch modifies filters slightly. Previously, they already checked to see if static property notation was provided or not. This extends that slightly to allow passing an optional second argument, a `null` or `object` value representing the instance being extracted or hydrated. For those filters that then use reflection, the `$instance` can be used as the primary argument, and the `$property` argument as the second. This approach allows the `ClassMethodsHydrator` to filter properly based on the specific instance under scrutiny. Additionally, this makes changes to `ClassMethodsHydrator` to: - Detect if an anonymous class was used. - Use the `spl_object_hash()` of that instance for caching the method list. - Pass the `$object` as the `$instance` argument to filters. Finally, I've added tests to each of the hydrators to verify they work as expected when presented with anonymous objects. Fixes laminas#25 Fixes laminas#26 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-hydrator
that referenced
this pull request
Oct 6, 2020
This patch modifies filters slightly. Previously, they already checked to see if static property notation was provided or not. This extends that slightly to allow passing an optional second argument, a `null` or `object` value representing the instance being extracted or hydrated. For those filters that then use reflection, the `$instance` can be used as the primary argument, and the `$property` argument as the second. This approach allows the `ClassMethodsHydrator` to filter properly based on the specific instance under scrutiny. Additionally, this makes changes to `ClassMethodsHydrator` to: - Detect if an anonymous class was used. - Use the `spl_object_hash()` of that instance for caching the method list. - Pass the `$object` as the `$instance` argument to filters. Finally, I've added tests to each of the hydrators to verify they work as expected when presented with anonymous objects. Fixes laminas#25 Fixes laminas#26 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
to weierophinney/laminas-hydrator
that referenced
this pull request
Oct 6, 2020
This patch modifies filters slightly. Previously, they already checked to see if static property notation was provided or not. This extends that slightly to allow passing an optional second argument, a `null` or `object` value representing the instance being extracted or hydrated. For those filters that then use reflection, the `$instance` can be used as the primary argument, and the `$property` argument as the second. This approach allows the `ClassMethodsHydrator` to filter properly based on the specific instance under scrutiny. Additionally, this makes changes to `ClassMethodsHydrator` to: - Detect if an anonymous class was used. - Use the `spl_object_hash()` of that instance for caching the method list. - Pass the `$object` as the `$instance` argument to filters. Finally, I've added tests to each of the hydrators to verify they work as expected when presented with anonymous objects. Fixes laminas#25 Fixes laminas#26 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new test case to reproduce issue with anonymous classes.
Description
Test to show bug with anonymous classes as described by #25