Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/php 8 support #32

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Feature/php 8 support #32

merged 5 commits into from
Oct 6, 2020

Conversation

weierophinney
Copy link
Member

@weierophinney weierophinney commented Oct 6, 2020 •
edited

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC yes
QA yes

Description

Adds PHP 8 support:

  • Adds ~8.0.0 as an additional PHP constraint.
  • Bumps minimum supported PHP version to 7.3.
  • Bumps PHPUnit version to ~9.3.0 (prior to 9.3 did not support PHP 8; 9.4 is currently broken under PHP 8).
  • Updates unit tests to work under new constraints; in particular, removes usage of Prophecy in favor of native PHPUnit mocks.

Fixes #29

@weierophinney weierophinney added this to the 4.0.0 milestone Oct 6, 2020
@boesing
Copy link
Member

boesing commented Oct 6, 2020 •
edited

Do we really need a major for this? 😱

I wonder if 8.0 works in the matrix. Afaik, there is no such version available (yet).

@boesing boesing added this to In progress in PHP 8.0 via automation Oct 6, 2020
@boesing boesing linked an issue Oct 6, 2020 that may be closed by this pull request
PHP 8.0 support #29
Closed
6 tasks
@weierophinney
Copy link
Member Author

Do we really need a major for this?

Yes, due to #30, next feature release will be a major.

@boesing
Copy link
Member

boesing commented Oct 6, 2020 •
edited

We probably should consider backporting PHP 8.0 as migrating laminas-hydrator to a new major is considered as PITA (so many other dependencies need to get a release).

https://packagist.org/packages/laminas/laminas-hydrator/dependents?
Imho, too many dependencies as this will happen in time.

@weierophinney
qa: prepare for 8.0
92505a9 
- Bumps minimum supported PHP version to 7.3.
- Adds `~8.0.0` as an additional allowed PHP constraint.
- Bumps supported PHPUnit version to 9.3 series; prior to 9.3 did not support PHP 8, 9.4.0 breaks under PHP 8 currently.
- Updates test matrix to drop 7.2 jobs and add 8.0 jobs.
- Updates test matrix to move CS, coverage, and phpstan to 7.4 job.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney
qa: update tests to work with PHPUnit 9.3 + PHP 8
e21ee78 
Prepares tests to work under PHP 8 + PHPUnit 9.3.
In particular, removes usage of prophecy in favor of PHPUnit mock objects.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney
qa: use "nightly" instead of "8.0" in travis config
9ff8b92 
8.0 env has not yet been created on Travis

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney changed the base branch from 4.0.x to 3.2.x October 6, 2020 17:56
@weierophinney weierophinney modified the milestones: 4.0.0, 3.2.0 Oct 6, 2020
@weierophinney
Copy link
Member Author

We probably should consider backporting PHP 8.0 as migrating laminas-hydrator to a new major is considered as PITA (so many other dependencies need to get a release).

https://packagist.org/packages/laminas/laminas-hydrator/dependents?
Imho, too many dependencies as this will happen in time.

Done - retargeted to 3.2.x and milestone 3.2.0.

@weierophinney
qa: move cs/coverage/static analysis checks to LATEST deps env
5f270f2 
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney
qa: bump minimum supported laminas-stdlib version to 3.3.0
822e8e7 
Fixes issue flagged by PHP 8.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney added a commit that referenced this pull request Oct 6, 2020
@weierophinney
docs: updates CHANGELOG to detail changes from #32
48ae3e0 
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit 822e8e7 into laminas:3.2.x Oct 6, 2020
PHP 8.0 automation moved this from In progress to Done Oct 6, 2020
@weierophinney weierophinney deleted the feature/php-8-support branch October 6, 2020 19:22
@github-actions github-actions bot mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
No open projects
PHP 8.0
  
Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
2 participants
@weierophinney @boesing