Fixed: handling non-scalars in NumberParse filter #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For a bugfix please use the current release branch, which is 2.23.x:
More on this topic can be found in the contributing guidelines: "What branch to issue the pull request against?" Thanks in advance! 👍🏻 |
fabiang
force-pushed
the
fix-numberparse-deprecation
branch
from
dc75ba3
to
5bbc11a
Compare
filter() now returns $value as-is for non-scalar and boolean values, which fixes triggering a deprection warning since PHP 8.1. Fix for issue laminas#105 Signed-off-by: Fabian Grutschus <github@lubyte.de>
fabiang
force-pushed
the
fix-numberparse-deprecation
branch
from
5bbc11a
to
68d7b15
Compare
|
Rebased to 2.23.x. |
|
Thanks @fabiang |
|
Oh thank you! I've tested this change in my current project and notices are gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter()now returns$valueas-is for non-scalar and boolean values, which fixes triggering a deprection warning since PHP 8.1.Fix for issue #105
Description