Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new documentation for Alnum validator #23

Merged
merged 6 commits into from
Mar 17, 2020

Conversation

froschdesign
Copy link
Member

Q A
Documentation yes
Bugfix yes

@froschdesign froschdesign linked an issue Mar 16, 2020 that may be closed by this pull request
docs/book/validators/alnum.md Outdated Show resolved Hide resolved
docs/book/validators/alnum.md Show resolved Hide resolved
docs/book/validators/alnum.md Outdated Show resolved Hide resolved
```php fct_label="Constructor Usage"
$validator = new Laminas\I18nn\Validator\Alnum(['allowWhiteSpace' => true]);

if ($validator->isValid('Abcd and 12')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better example, like: 5 apples, 12th chapter etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, I would wait for new tutorials and then we can update the content.
I hope that we can achieve consistency and reuse of the same example across the documentation.

Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@froschdesign Rebased. LGTM 👍

@michalbundyra
Copy link
Member

Thanks, @froschdesign!

michalbundyra added a commit that referenced this pull request Mar 17, 2020
@michalbundyra michalbundyra merged commit d89fa8f into laminas:master Mar 17, 2020
@froschdesign froschdesign deleted the hotfix/docs/alnum branch March 17, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation update
2 participants