ArrayInput: Accept non-array input without throwing an exception
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Steel <george@net-glue.co.uk>
Alters the behaviour of `ArrayInput` so that non-array input is deemed a validation failure instead of an exceptional condition. Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Mar 26, 2024
| @@ -4,60 +4,30 @@ | |||
|
|
|||
| namespace Laminas\InputFilter; | |||
|
|
|||
| use function gettype; | |||
| use Laminas\Validator\IsArray; | |||
|
Marked as bug + improvement on purpose, BTW: it changes dependencies, so it can't go to a patch version |
|
Thankyou @Ocramius 🙏 |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function resetValue() |
There was a problem hiding this comment.
@gsteel After removing this, default value is null now instead of empty array. It looks like a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alters the behaviour of
ArrayInputso that non-array input is deemed a validation failure instead of an exceptional condition.Fixes #104
This could be considered a BC break, but it would never have previously been possible for a non-array value to be validated/filtered here, so it's more likely that no-one ever used this input type without wrapping its execution in a try/catch block.
Assuming users are using this input type, and they are wrapping with try, then the introduction of the IsArray validator will still provide graceful validation failure.