Update to laminas-coding-standard v2 series #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates to laminas-coding-standard 2.2 - Applies ruleset Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Majority have to do with Psalm inferring ever-so-slightly different return values for data providers than what is documented, even when what is documented is correct. Other errors were likely present before, but because I touched the files, Psalm re-scanned and reflagged; these were mostly of the MixedAssignment variety. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
7.4 was what I was testing against, and what I plan for the next minor (2.13.0). Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for PHP 8.1, we need to first update to a version of laminas-coding-standard that will work with PHP 7.4 forward, which means moving to laminas-coding-standard 2.2.
This patch updates the constraint in
composer.json, and updates thephpcs.xml.distto reflect the new schema.I then applied fixes, and resolved Psalm errors that arose due to touching files again.