Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psalm integration #18

Merged
merged 8 commits into from Dec 3, 2021
Merged

Psalm integration #18

merged 8 commits into from Dec 3, 2021

Conversation

ghostwriter
Copy link
Contributor

Q A
New Feature yes
QA yes

Description

closes #10

@froschdesign froschdesign added this to To do in Psalm via automation Oct 11, 2021
@Ocramius Ocramius added this to the 2.12.0 milestone Dec 1, 2021
@Ocramius Ocramius changed the base branch from 2.11.x to 2.12.x December 3, 2021 11:40
@Ocramius Ocramius self-assigned this Dec 3, 2021
ghostwriter and others added 8 commits December 3, 2021 12:41
@ghostwriter @Ocramius
Create psalm.xml.dist
e63b1a1 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter @Ocramius
Require vimeo/psalm
41f3e5e 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter @Ocramius
Require psalm/plugin-phpunit
6458f2e 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter @Ocramius
Add static-analysis composer script
380a6b4 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter @Ocramius
Create psalm-baseline.xml
e1ab820 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius
Updated composer.lock to contain latest vimeo/psalm and `psalm/pl…
14705d4 
…ugin-phpunit`
@Ocramius
Downgraded to a dependency set compatible with php: 7.3.33 (current…
0fac3da 
… CI version)
@Ocramius
Regenerated psalm baseline to include all newly detected (pre-existin…
dcea985 
…g) issues
Ocramius
Ocramius approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Thanks @ghostwriter!

@Ocramius Ocramius merged commit 174ef31 into laminas:2.12.x Dec 3, 2021
Psalm automation moved this from To do to Done Dec 3, 2021
@ghostwriter ghostwriter deleted the feature/psalm-integration branch December 3, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@snapshotpl snapshotpl snapshotpl approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
Psalm
  
Done
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
4 participants
@ghostwriter @Ocramius @snapshotpl @froschdesign