Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When set -f option, no set -f option automatically #17

Closed
weierophinney opened this issue Dec 31, 2019 · 5 comments
Closed

When set -f option, no set -f option automatically #17

weierophinney opened this issue Dec 31, 2019 · 5 comments

Comments

@weierophinney
Copy link
Member

Zend\Mail\Transport\SendMail always append envelope-from parameter.
But I want to set any envelope-from.
In this PR, only when not set option -f, set -f option automatically.
This means if I set -ffoo@example.com or -bs -ffoo@example.com, Zend\Mail\Transport\Sendmail doesn't set -f option.


Originally posted by @tzmfreedom at zendframework/zend-mail#227

@weierophinney
Copy link
Member Author

without getting deeper to the actual changes, have some thoughts:

  1. seems weird to have a negative parameter. how about set positive parameter which is b default true, and can be set as false.
  2. maybe have a specific option (envelope related) rather generic "no override" as behavior could be different if want/want not to override some other parameter.

Originally posted by @glensc at zendframework/zend-mail#227 (comment)

@weierophinney
Copy link
Member Author

Thank you for you reply and advice !

I rethink, revise my code and changed this PR goal.

On this PR, only when not set option -f, set -f option automatically.
This means if I set -ffoo@example.com or -bs -ffoo@example.com, Transport\Sendmail doesn't set -f option.
So there is no negative parameter, no additional method.


Originally posted by @tzmfreedom at zendframework/zend-mail#227 (comment)

@weierophinney
Copy link
Member Author

you should update PR title as well. and the body is a bit hard to read as well.


Originally posted by @glensc at zendframework/zend-mail#227 (comment)

@samsonasik
Copy link
Member

I've created PR #104 for it

@tzmfreedom
Copy link

@samsonasik Thank you!!

weierophinney pushed a commit to samsonasik/laminas-mail that referenced this issue Aug 6, 2020
…ically

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
…ically

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
…ically

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants