-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft POP3 XOAUTH2 #200
Conversation
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @griesi007 for the improvements over the first PR.
Check the few changes I pinpointed and let's see how the shape looks.
Please rebase the PR as the first step.
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
# Conflicts: # src/Protocol/Pop3.php # src/Protocol/Pop3/Xoauth2/Microsoft.php # src/Protocol/Xoauth2/Xoauth2.php # test/Protocol/Pop3/ResponseTest.php # test/Protocol/Pop3/Xoauth2/MicrosoftTest.php # test/Protocol/Xoauth2/Xoauth2Test.php
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
Signed-off-by: griesi007 <noreply@12live.de>
@Slamdunk : what´s the current status on this pull request? All requested changes habe been applied some time ago. Is it still considered to be accepted and merged? |
I'm sorry for the late reply, indeed I forgot this. I don't know how to handle this properly though: I am not able to check that this PR works, I don't have an Office365 account. @Ocramius @weierophinney beside the formal correctness of the code and adherence to |
@Slamdunk if you are happy with just the unit test, then let's move it forward. |
Signed-off-by: griesi007 noreply@12live.de
Add support for Microsoft POP3 via modern authentication in addition to rejected pull request #199 with required integration tests