-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return-type for Sendmail::prepareSubject
and the Sendmail::prepareParameters
#242
Fix return-type for Sendmail::prepareSubject
and the Sendmail::prepareParameters
#242
Conversation
…Parameters have been fixed
…mail has been added.
This reverts commit 7c2afd0.
This reverts commit f9f43a3.
This reverts commit f07d863.
…sending mail has been added." This reverts commit fab234c.
…ng' for Laminas\Mail\Transport\Envelope::getFrom is not nullable, but 'null|string' contains null (see https://psalm.dev/144)" has been fixed
@Ocramius |
psalm-baseline.xml
Outdated
@@ -1663,9 +1663,6 @@ | |||
</MissingReturnType> | |||
</file> | |||
<file src="src/Transport/Envelope.php"> | |||
<InvalidNullableReturnType> | |||
<code>string</code> | |||
</InvalidNullableReturnType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you've removed the InvalidNullableReturnType
from src/Transport/Envelope.php
, but I rather not touch the Envelope class properties as it could be seen as a BC Break.
In #241 (comment) the only InvalidNullableReturnType
removal I suggest is the src/Transport/Sendmail.php
, which in this PR is still in place
This reverts commit 2274fbc52236c46266934e2bfa9cc1cee801b8e8.
This reverts commit 6514c48c1bada0d5cdb2ddad0a66f7d509506a50.
…pe 'string' for Laminas\Mail\Transport\Envelope::getFrom is not nullable, but 'null|string' contains null (see https://psalm.dev/144)" has been fixed" This reverts commit d5038a6d544e27929a7da242758ee76be80da089.
….php instead of src/Transport/Envelope.php Signed-off-by: Artemii Karkusha <artemii.karkusha@gmail.com>
Signed-off-by: Artemii Karkusha <artemii.karkusha@gmail.com>
Thank you |
Sendmail::prepareSubject
and the Sendmail::prepareParameters
Type of returning for functions of the prepareSubject and the prepareParameters have been fixed
#240