Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support php 7, add php 8.2 support #138

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Drop support php 7, add php 8.2 support #138

merged 3 commits into from
Oct 19, 2022

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Oct 16, 2022

No description provided.

@fezfez
Copy link
Contributor Author

fezfez commented Oct 16, 2022

i see that 4.x have migrated to laminas/laminas-coding-standard:2.4.x, i think that would lead to a lot of conflict if i do it too, but ^1.0 is not compatible with php 8.x

@fezfez fezfez mentioned this pull request Oct 16, 2022
Closed
@fezfez
Drop support php 7, add php 8.2 support
1e23144 
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez
Drop support php 7, add php 8.2 support
338c782 
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez fezfez force-pushed the php8.2-2 branch 10 times, most recently from 99f7213 to 41fa8a0 Compare October 18, 2022 10:40
@fezfez
Copy link
Contributor Author

fezfez commented Oct 18, 2022

@Ocramius : it seem to finally work.

For PHPCodeSniffer (has i say before)

i see that 4.x have migrated to laminas/laminas-coding-standard:2.4.x, i think that would lead to a lot of conflict if i do it too, but ^1.0 is not compatible with php 8.x

Ocramius
Ocramius requested changes Oct 18, 2022
View reviewed changes
test/Controller/MiddlewareControllerTest.php Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@fezfez fezfez force-pushed the php8.2-2 branch 5 times, most recently from c7b166b to 731f16f Compare October 18, 2022 11:25
@fezfez
Copy link
Contributor Author

fezfez commented Oct 18, 2022

@Ocramius seem to work

@fezfez
merge
ad9267a 
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez fezfez requested a review from Ocramius October 18, 2022 11:36
@fezfez fezfez changed the title Drop support php 7, add php 8.2 support without update to laminas/laminas-coding-standard:^2.0 Drop support php 7, add php 8.2 support Oct 18, 2022
@fezfez
Copy link
Contributor Author

fezfez commented Oct 19, 2022

@Ocramius ping 🤓

@Ocramius Ocramius added Enhancement dependencies Pull requests that update a dependency file labels Oct 19, 2022
@Ocramius Ocramius added this to the 3.4.0 milestone Oct 19, 2022
@Ocramius Ocramius self-assigned this Oct 19, 2022
Ocramius
Ocramius approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @fezfez!

@Ocramius Ocramius merged commit 4ccca21 into laminas:3.4.x Oct 19, 2022
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fezfez @Ocramius