Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10 : Fix incorrect DbSelect::count() when setted \PDO::ATTR_CASE => \PDO::CASE_LOWER in driver options #11

Merged
merged 10 commits into from
Sep 10, 2020
Merged

Fixes #10 : Fix incorrect DbSelect::count() when setted \PDO::ATTR_CASE => \PDO::CASE_LOWER in driver options #11

merged 10 commits into from
Sep 10, 2020

Commits on Aug 5, 2020

  1. Fixes laminas#10 : Fix incorrect DbSelect::count() when setted \PDO::… 

    …ATTR_CASE => \PDO::CASE_LOWER in driver options

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    4f34a05 View commit details
    Browse the repository at this point in the history

  2. return early self::ROW_COUNT_COLUMN_NAME when driver is not a Pdo ins… 

    …tance

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    fd6e67b View commit details
    Browse the repository at this point in the history

  3. mock getAdapter()->getDriver() 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c22baae View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. simplify test with add smaller "c" column in columns list 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    17fc4a4 View commit details
    Browse the repository at this point in the history

  2. add missing (int) casting 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    8ebf3e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. make column name based on constant with strtolower 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    25b01b4 View commit details
    Browse the repository at this point in the history

  2. make column name based on constant with strtolower 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    e76a51f View commit details
    Browse the repository at this point in the history

  3. make column name based on constant with strtolower 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    389ebf0 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. use default column in uppercase, use lower case as alternative on usa… 

    …ge count()

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    ab146a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. add locateRowCount() helper method to use array_key_exists 

    Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @samsonasik
    samsonasik committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    56280e5 View commit details
    Browse the repository at this point in the history