Adds new parameter for render method to allow custom variables for view script #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
froschdesign
commented
Aug 29, 2020
froschdesign
commented
| Q | A |
|---|---|
| Enhancement | yes |
…ering Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
michalbundyra
approved these changes
Aug 29, 2020
| { | ||
| public function render( | ||
| View\Renderer\RendererInterface $view = null, | ||
| array $params = [] |
There was a problem hiding this comment.
@froschdesign adding argument to public method which is not final/internal (also class is not final/internal) is a BC Break. Added label and milestone for that PR.
There was a problem hiding this comment.
Correct! 👍
This pull request can wait and was only opened so that I do not forget the feature myself.
|
The rendering will be extracted in the next major version, so this extension is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.