Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PHP 8.0 Syntax and constructor promotion #46

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com

Q A
QA yes

Description

Since composer.json require php 8.0, php 8.0 syntax can constuctor promotion can be applied.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik
Copy link
Member Author

All green 🎉

@Ocramius Ocramius added this to the 2.15.0 milestone Oct 24, 2022
@Ocramius Ocramius self-assigned this Oct 24, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @samsonasik!

@Ocramius Ocramius merged commit 83c3ff8 into laminas:2.15.x Oct 24, 2022
@samsonasik samsonasik deleted the apply-php80 branch October 24, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants